[Crashlytics] Sync signal/exception handler installation#15576
[Crashlytics] Sync signal/exception handler installation#15576
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request makes the installation of Crashlytics signal and mach exception handlers synchronous by removing the dispatch_group_async wrappers. This is a sensible change that improves predictability during initialization, which is crucial for compatibility with other crash reporters, as noted in the changelog. The resulting code is cleaner and more straightforward. My review found only a minor formatting issue.
|
Reopening, I thought this was a different PR. This one is still waiting for review. |
ncooke3
added
the
needs-jules-review
4 participants
Fix #15383
Here's a Gemini driven PR that still needs end-to-end testing and review. Gemini comments below:
Summary:
This PR modifies FIRCLSContextInitialize to install signal and mach exception handlers synchronously. Previously, these handlers were installed asynchronously on a background queue, which created a race condition for other runtime environments (like Mono, Xamarin, Unity) that need to chain signal handlers. By ensuring synchronous installation, these environments can reliably install their handlers after Crashlytics initialization and maintain a proper signal chain.
Changes: